Comment Class: huge history

Help / Discuss
#1

Hi,

I was sorting pages of my Wiki by Creation date and I have seen the Comment Class page (I have never worked on) appearing … when I look at the history of this page it contains more than 1,800 versions; Where do they come from?
see [XWiki Comment Class] at http://tutos.myxwiki.org/xwiki/bin/view/XWiki/XWikiComments

Please note:

  • not sure if these “automatic saved” are linked to myxwiki.org or not
  • as far as I can see there are no change done on this page, just a save
  • maybe this kind of “periodic and automatic” saves performed farm wide on pages are the reason why Solr keeps indexing (currently more than 228287 documents pending which leads a document created 5 hours ago in my Wiki to still not be available in Solr search results :sneezing_face:) and regularly causing low MyXwiki respond time.
#2

Looks like a bug in the XWikiComments class initializer which keep thinking it needs to modify something and then don’t. Would be great if you could create a jira issue on https://jira.xwiki.org with a XAR export of your XWikiComments page so that we try to reproduce and debug why it behave like this.

After looking at the diff it sounds like comments and annotations initializers fighting each other (because they actually update the same class by default and looks like they are not in sync anymore).

I don’t think so, the bug you have seems very specific to this class and could not explain 228287 documents added to the indexing queue.

#3

@xrichard thanks for reporting the issue, I’ll create the jira issue for you and push a fix :wink:

#4

Thanks for your answers.

@atallahade attached the XAR of the XWiki Comment Class of my Wiki if it can help to solve this bug (to bypass the upload limitation of this forum, I renamed the file to *.txt ).

XWiki.XWikiComments.xar.txt (1.8 KB)

Can you please add a link to the Jira issue?

#5

Thanks for trying to help us but we already fixed the issue: https://jira.xwiki.org/browse/XWIKI-15812

#6

@tmortagne I don’t understand why the indexer is always running on myxwki, causing new pages of my Wiki to be searchable several hours (or even days) after their last save.

I’m quite convinced: there are automatic page updates (“user activity” on mywiki farm could not explain this behavior). What do you think?

#7

Many thanks for this quick fix :+1:.

I guess that the fix won’t purge the “huge history” of the comment class page … is there any impact to have such a big history for one page?

#8

What I mean is that the XWikiComments issue is not enough to explain alone this size of solr indexer queue.

#9

It’s a problem when manipulating the history but this page being a class it’s not the kind of document on which it happen much.

#10

We fully agree and I’m still wondering what can explain Solr indexer queue on myxwiki?

#11

No idea yet, will definitely need to debug it when I can find some time.

#12

@tmortagne Ok, what’s the best way to be kept informed of your work / findings on this issue (it concerns all wikis hosted on myxwiki farm)?

#13

I guess the best would be to create an issue about this problem on https://jira.xwiki.org/browse/XINFRA.

#14

Waiting for next xwiki release + deployment on myxwiki to check that https://jira.xwiki.org/browse/XWIKI-15812 solves this issue.

#15

Confirmed: no more automatic page history creation + bulk delete in page history is working again in Xwiki 10.10.
Many thanks :heart_eyes:!